Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Ubuntu broke overlayfs again #1801

Conversation

adrianreber
Copy link
Member

Switch to non overlaysfs tests for Podman and Docker.

Switch to non overlaysfs tests for Podman and Docker.

Signed-off-by: Adrian Reber <areber@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1801 (65c4e42) into criu-dev (eaca57b) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           criu-dev    #1801      +/-   ##
============================================
- Coverage     69.27%   68.91%   -0.36%     
============================================
  Files           128      128              
  Lines         32089    33191    +1102     
============================================
+ Hits          22229    22873     +644     
- Misses         9860    10318     +458     
Impacted Files Coverage Δ
criu/uffd.c 76.47% <0.00%> (-2.90%) ⬇️
criu/cr-check.c 61.94% <0.00%> (-0.25%) ⬇️
criu/sk-unix.c 73.94% <0.00%> (-0.03%) ⬇️
criu/fdstore.c 61.19% <0.00%> (ø)
criu/pidfd-store.c 66.18% <0.00%> (ø)
criu/unittest/mock.c 8.51% <0.00%> (ø)
compel/src/lib/infect-util.c 33.33% <0.00%> (ø)
criu/arch/x86/include/asm/restorer.h
criu/arch/x86/crtools.c
criu/include/linux/mount.h
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaca57b...65c4e42. Read the comment docs.

Copy link
Member

@rst0git rst0git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianreber adrianreber merged commit 22ec298 into checkpoint-restore:criu-dev Apr 5, 2022
@@ -21,7 +21,10 @@ add-apt-repository \

. /etc/lsb-release

echo '{ "experimental": true }' > /etc/docker/daemon.json
# overlayfs behaves differently on Ubuntu (18.04) and breaks CRIU
# https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1857257
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the old bug, isn't it? I think we need to file a new one.

@avagin
Copy link
Member

avagin commented Apr 5, 2022

Sorry, I have to revert this change. First, it links the old ubuntu issue. Second, it is unclear what kernel is broken and what is broken. Feel free to create a new PR.

@adrianreber
Copy link
Member Author

Sorry, I have to revert this change. First, it links the old ubuntu issue. Second, it is unclear what kernel is broken and what is broken. Feel free to create a new PR.

It is the same bug. They always reintroduce the broken patch.

@adrianreber
Copy link
Member Author

@avagin can you disable the broken tests until they are fixed. Not really helpful to have known broken CI tests running.

@avagin
Copy link
Member

avagin commented Apr 5, 2022

@adrianreber How many times have you seen that I disabled broken tests due to bugs in the redhat kernel? It doesn't work this way, sorry. When you are working on CRIU, you are the CRIU engineer and your goal is that CRIU works on all major platforms. I don't ask you to fix bugs in Ubuntu kernels, but I think we have to do initial investigation and describe the issue in a bug for a proper project.

@adrianreber
Copy link
Member Author

@adrianreber How many times have you seen that I disabled broken tests due to bugs in the redhat kernel? It doesn't work this way, sorry. When you are working on CRIU, you are the CRIU engineer and your goal is that CRIU works on all major platforms. I don't ask you to fix bugs in Ubuntu kernels, but I think we have to do initial investigation and describe the issue in a bug for a proper project.

Not sure what this has to do with the Red Hat kernel, but I have tested it on the mentioned Ubuntu kernel and it is the same error message. This is again #860. We know how to work around it. If you do not want the workaround, then disabling seems the better solution than having CI errors. This error exists since 2019 and it keeps coming back.

@avagin
Copy link
Member

avagin commented Apr 5, 2022

@adrianreber I am only asking you to report the issue to Ubuntu engineers. In the comment, you link the bug that have been closed. If we don't reopen it, it will never be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants