amdgpu: Set PLUGINDIR to /usr/lib/criu

[rst0git]

This patch fixes the following error which appears when building criu packages for Ubuntu/Debian.

mkdir: cannot create directory '/var/lib/criu': Permission denied

[rst0git]

cc: @rajbhar

[codecov-commenter]

Codecov Report

Merging #1876 (795246e) into criu-dev (37ea8c5) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           criu-dev    #1876   +/-   ##
=========================================
  Coverage     68.98%   68.98%           
=========================================
  Files           128      129    +1     
  Lines         33346    33349    +3     
=========================================
+ Hits          23003    23006    +3     
  Misses        10343    10343           

Impacted Files	Coverage Δ
criu/uffd.c	79.36% <0.00%> (-0.48%)	⬇️
criu/include/vma.h	100.00% <0.00%> (ø)
criu/include/criu-log.h	100.00% <0.00%> (ø)
criu/cr-restore.c	67.25% <0.00%> (+0.18%)	⬆️
criu/plugin.c	24.21% <0.00%> (+0.59%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ea8c5...795246e. Read the comment docs.

[jpalus]

Would be good if this install target respected DESTDIR as well.

[adrianreber]

I am not really happy with the plugin location in /var. I think it should be somewhere in /usr.

[jpalus]

To add even more concerns regarding amdgpu plugin:

• PLUGINDIR from Makefile should be used as #define CR_PLUGIN_DEFAULT value via build flag -DCR_PLUGIN_DEFAULT=\"$(PLUGINDIR)\"
• not sure where drm.h header comes from in #include <drm/drm.h>
• pkgconfig --cflags libdrm flags are not used

[rst0git]

@jpalus and @adrianreber Thank you for your comments. I've updated the pull request.

[adrianreber]

This makes more sense to me than the previous location. 👍

Please rebase to pick up your CI linter run fix.

[rst0git]

Thanks, I've rebased this pull request.