image: core -- Reserve start_time field #905
Conversation
|
You need to sign off your patches like described at https://criu.org/How_to_submit_patches#Sign_your_work And a bit more details why this change, even as simple as it is, is needed. |
valeriyvdovin
force-pushed
the
criu-dev
branch
from
df3f2d7 to
05ef3df
Compare
To ensure consistency of runtime environment processes within a container need to see same start time values over suspend/resume cycles. We introduce new field to the core image structure to store start time of a dumped process. Later same value would be restored to a newly created task. In future the feature is likely to be pulled here, so we reserve field id in protobuf descriptor. Signed-off-by: Valeriy Vdovin <valeriy.vdovin@virtuozzo.com>
valeriyvdovin
force-pushed
the
criu-dev
branch
from
05ef3df to
cc04560
Compare
|
@valeriyvdovin why do you want to reserve it? |
|
Ah, I've noticed your |
This 'start_time' field is rather straight-forward and is the most basic stat of a process and should be covered by criu's basic functionality, so in our vz criu we definitely want to support it to fix issues with processes that depend on correct value of this field and in the light of that I don't see any reason to not reserve it in mainline, so we could pull it here later |
|
We've already had these problem in VZ7 criu, if we use some id in core image we have a risk that these same field id will be used in ms criu, and we won't to have compatible images between mscriu and vzcriu. Last time we've introduced task_core_entry_VZ730 =) https://src.openvz.org/projects/OVZ/repos/criu/browse/images/core.proto#27 And we don't want this pain again. I'm not sure how much time it may take to implement start_time in mscriu, and how much time it will take to add proper interface for it in mskernel. But we can at least try implementing it in vzcriu and vzkernel first =). |
To ensure consistency of runtime environment processes within a container need to see same start time values over suspend/resume cycles. We introduce new field to the core image structure to store start time of a dumped process. Later same value would be restored to a newly created task. In future the feature is likely to be pulled here, so we reserve field id in the core's protobuf descriptor.