-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Geos to Report #49
Conversation
@erdey when I tested this locally without any default, I added a default value for the result in a new commit. This is what is returned now when I make the calls if there are no geos: does this seem like the correct behavior? I didn't see a pattern for testing this in |
@aaronapayne I think empty array for the data is a good default. I also don't see any examples of testing similar behavior, so I'll defer to the primary maintainers on whether we need to test it. |
@erdey @aaronapayne
I tested these changes locally and it seems to be working fine. ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌎
@aaronapayne Thank you for this contribution! 🙌🏻 |
@aaronapayne we bumped to 1.5.3, thank you so much! 👌 |
Thanks all! I appreciate your help on this! 🙌 |
Adds geos to the report object. This is supported per the checkr docs, but isn't currently supported in this gem.