Handle error string returned in the JSON-RPC response #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we provide a workaround for servers that don't follow the JSON-RPC 2.0 specification for error objects. According to the specification, an error should be an object containing `code`, `message`, and `data` properties (see: https://www.jsonrpc.org/specification#error_object). Unfortunately, Electrs returns an error as a string (see: Blockstream/esplora#453). We define an error unmarshaling function to handle both types of errors.
It would be usefull to include value that failed unmarshalling in the debug mode log message.
Handle error string returned in the JSON-RPC response
|
@checksum0 will you be interested in merging this PR? We confirmed errors are handled correctly with integration tests in keep-network/keep-core#3567. |
Here we add support for WebSocket protocol. With this change the client will support all connection types defined by the electrum protocol: `tcp`, `ssl`, `ws` and `wss`. The WebSocket client initialization expects remote server details to be provided as URL including a scheme and host, e.g. `tcp://electrum.io:50001`.
The `NewClient` function should be used to initialize the client. The function resolves transport protocol from the URL. It supports all four protocols: `tcp`, `ssl`, `ws` and `wss`.
After sending a close message to the server we need to wait for the response or force the conncetion closure after a timeout.
Support WebSocket protocol
|
Closing in favor of #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5
Here we provide a workaround for servers that don't follow the JSON-RPC 2.0 specification for error objects.
According to the specification, an error should be an object containing
code,message, anddataproperties (see: https://www.jsonrpc.org/specification#error_object).Unfortunately, Electrs returns an error as a string (see: Blockstream/esplora#453).
We define an error unmarshaling function to handle both types of errors.
Sample outputs from servers that the client has to handle:
ElectrumX
Fulcrum
Esplora/Electrs