Fix text expander not working correctly in lists #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kizu
force-pushed
the
fix-text-expander
branch
from
1dc8638 to
1d37484
Compare
kizu
force-pushed
the
fix-text-expander
branch
from
1d37484 to
b4ecff6
Compare
cheeaun
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to fix an issue that I had for a while: when trying to autocomplete a mention when inside a list, pressing
enterclosed the text-expander and created a new list, leaving the mention unfinished.Screen.Recording.2024-12-26.at.11.51.40.mov
Screen.Recording.2024-12-26.at.11.54.29.mov
Did it by introducing a ref that is toggled on when the text-expander activates and off when it deactivates, and then checking this ref when doing the action on
enter.