fix(replaceWith): Fix replacing element with itself (#1581)

Fixes #962
cheeriojs · Dec 22, 2020 · 88ae636 · 88ae636
1 parent 3b35ae4
commit 88ae636
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/api/manipulation.js b/lib/api/manipulation.js
@@ -646,7 +646,10 @@ exports.replaceWith = function (content) {
 
     // Completely remove old element
     uniqueSplice(siblings, index, 1, dom, parent);
-    el.parent = el.prev = el.next = null;
+
+    if (dom.indexOf(el) < 0) {
+      el.parent = el.prev = el.next = null;
+    }
   });
 
   return this;

diff --git a/test/api/manipulation.js b/test/api/manipulation.js
@@ -1391,6 +1391,16 @@ describe('$(...)', function () {
       expect($.html($src)).to.equal('<h2>hi <div>here</div></h2>');
     });
 
+    it('(self) : should be replaced after replacing it with itself', function () {
+      var $ = cheerio.load('<a>foo</a>', null, false);
+      var replacement = '<a>bar</a>';
+      $('a').replaceWith(function (i, el) {
+        return el;
+      });
+      $('a').replaceWith(replacement);
+      expect($.html()).to.be.equal(replacement);
+    });
+
     it('(str) : should accept strings', function () {
       var $src = $('<h2>hi <span>there</span></h2>');
       var newStr = '<div>here</div>';