Fix unexpected behavior while querying child #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case is intended to highlight two unwanted behaviors: - The first one is related to issue #742. While using css-select v1.0.0, the child selector '>' would also include indirect descendants and this test case would return '3'. - The second issue (discussed here: #780 (comment) ) comes while using css-select v1.2.0. In such a case, the context of the '>' selector is the first 'bar' and not 'foo' as intended, which causes a resulting length of '2'.
The issue, after upgrading css-select to v1.2.0, was due to an improper context of options passed to 'CSSselect()'.
|
@jugglinmike No, I did not. It follows a suggestion I made, @Delgan probably wanted to give credit (which I appreciate!). A mention in the commit message would be better IMHO, but I don't care enough about it to force a change. LGTM otherwise! |
|
+1 on this, having the same issue. |
Merged
|
This indeed fixes the issue, thanks :-) I've seen elsewhere in the repo that releases are request-based, @fb55 is there anything missing for this PR to it be merged and a version containing the fix to be released? Thanks |
fb55
added a commit
that referenced
this pull request
Jan 28, 2016
Fix unexpected behavior while querying child
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the solution of fb55 and I added a unit test to ensure that #742 and #780 was correctly fixed.