Version bump: Support cheerio 1.0.0-RC3 with parse5. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a diff conflict due to #76. Can you rebase? |
|
@curbengh I'd like to do after I read new code because other PRs has been merged since I write this PR, and hope maintainers can read cheeriojs/cheerio#1198 to understand what cause this problem, and they may have other opinions. |
|
I would like to make another PR and close this since I think this will make it easier for me to merge new code... |
|
Please refer to #85 for my new code, sorry for everyone comes here. |
|
That explains I'll update my package to refer to the new PR instead. Thanks for the update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cheerio 1.0.0-RC3 uses parse5 instead of htmlparser2 for HTML parsing, but parse5 decode all entities (include
<,>) and does not supportdecodeEntitiesandnormalizeWhitespace. This PR adds escaping function to support parse5 and updated cheerio dependence version.Solves cheeriojs/cheerio#1198.
Needs a dependence version update for cheerio because this cannot keep compatibility with older cheerio (which uses htmlparse2 as HTML parser), older cheerio should use older dom-serializer.