Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

인텔리제이 PR & Code Review #24

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Conversation

cheese10yun
Copy link
Owner

작업 내용

  • 코드리뷰용 테스트

@coveralls
Copy link

coveralls commented Jul 18, 2020

Pull Request Test Coverage Report for Build 37

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.75%

Totals Coverage Status
Change from base Build 36: 0.0%
Covered Lines: 30
Relevant Lines: 32

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           5        5           
  Lines          32       32           
  Branches        1        1           
=======================================
  Hits           30       30           
  Misses          2        2           
Impacted Files Coverage Δ
src/main/java/com/sample/github/user/User.java 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8cfd0e...974109c. Read the comment docs.

@@ -30,4 +30,4 @@ public User(Email email, Address address) {
this.email = email;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인텔리제이에서 코드리뷰에 대한 comment를 추가 할 수 있습니다.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

답글도 가능합니다.

@cheese10yun cheese10yun merged commit da19cb2 into master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants