Fix #69 by ignoring cfn-signal errors #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tensibai <tensibai@iabis.net>
Tensibai
changed the title
|
thank you for your contribution!! |
irvingpop
approved these changes
Feb 5, 2020
|
hey @thomascate since I can't merge this myself anymore, would you mind merging and then tagging a release? |
|
Sure, looks like the build failures are something unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring any cfn-signal error to avoid triggering the trap and setting the instance unlhealthy when cfn-signal can't signal the wait resource anymore.
During a creation process the missing signal to the wait handle would trigger a rollback of the stack creation anyway.
This fix issue #69 (commit text messed up with another project :D)