-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knife bootstrap custom client.rb config #183
Conversation
Knife bootstrap currently only allows a select few `client.rb` parameters | ||
to be specified during bootstrap. This RFC is an attempt to allow users | ||
to be able to specify `client.rb` parameters that are not directly known | ||
to knife bootstrap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This RFC proposes a solution to allow users to pass bulk configuration data to knife bootstrap
to be placed in the client.rb
before the first chef-client run.
3c105f2
to
c155ec9
Compare
|
||
## Background | ||
|
||
The `knife-bootstrap` command supports a small subset of possible parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*knife bootstrap
(no dash)
c155ec9
to
5f3a69f
Compare
5f3a69f
to
4c08780
Compare
switch `--client_d_dir`. The files will be loaded in alphabetical | ||
order. Knife will still sync all files under `client.d`, however | ||
only top-level files will the automatically loaded. The block to | ||
do this would look something like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were talking in IRC today, the client_d directory should default to like #{Chef::Config[:config_dir]}/client.d" and should be a Chef::Config setting like Chef::Config[:client_d_dir] that you could override in your knife.rb or client.rb or whatever. but don't add a CLI arg like --client_d_dir
unless we're convinced we need it.
@chef/rfc-editors this looks decided, can you merge or should it be a topic at our next meeting? |
@nathenharvey I was holding off to see if @btm's comment was addressed, and it appears it has. 😄 I will merge. |
Knife bootstrap custom client.rb config
Knife bootstrap currently only allows a select few
client.rb
parametersto be specified during bootstrap. This RFC is an attempt to allow users
to be able to specify
client.rb
parameters that are not directly knownto knife bootstrap.