add --binstub-source option #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
force-pushed
the
lcg/binstub-source
branch
from
4f382ea
to
6f6bd99
Compare
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
lamont-granquist
added a commit
to chef/appbundle-updater
that referenced
this pull request
Apr 24, 2019
passed into appbundler see chef/appbundler#53
lamont-granquist
added a commit
to chef/appbundle-updater
that referenced
this pull request
Apr 24, 2019
passed into appbundler see chef/appbundler#53 Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to copy binstubs from some stashed ("source") location into the bin directory in the gem_dir.
This is here in appbundler because it makes it easier to re-appbundle and keeps all the logic for the mangling we do of the gem to "prep" it for omnibus in one location.
This makes it easy to do things like the kitchen-tests in chef/chef which need to patch in the new gem and call appbundle-updater and also need this step (it made more sense to do this here than in appbundle-updater or in the kitchen configuration there).
This is now growing enough in terms of configuration state that I'm wondering if we just shouldn't have an Appbundler.rb file in the root of the gem/project with all the configuration.