Warn on unresolved specs #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These produce horrible perf degredation in rubygems internally: rubygems/rubygems#2761 Due to appbundler this "should" not happen, but due to: f01aea0 And due to ruby now shipping with bundler, we were getting two versions of bundler and an unresolved spec, and therefore rubygems had significant performance issues. All that is required is correctly activating bundler in the appbundler binstub and the spec becomes resolved and the perf issues go away. This commit just adds some warning about the issue so that people report it, with a clear bit of text to not just ignore it. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
tas50
reviewed
May 11, 2019
| @@ -330,6 +330,11 @@ def load_statement_for(bin_file) | |||
| spec = Gem::Specification.find_by_name("#{name}") | |||
| end | |||
|
|
|||
| unless Gem::Specification.unresolved_deps.empty? | |||
| $stderr.puts "APPBUNDLER WARNING: unresolved deps are CRITICAL performance bug, this MUST be fixed" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These produce horrible perf degredation in rubygems internally:
rubygems/rubygems#2761
Due to appbundler this "should" not happen, but due to:
f01aea0
And due to ruby now shipping with bundler, we were getting two versions
of bundler and an unresolved spec, and therefore rubygems had
significant performance issues. All that is required is correctly
activating bundler in the appbundler binstub and the spec becomes
resolved and the perf issues go away.
This commit just adds some warning about the issue so that people report
it, with a clear bit of text to not just ignore it.