force bundler activation #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after we've activated all the other gems, force bundler activation. since we're appbundling we've already activated all the gems and have all the constraints loaded. but bundler will not put bundler in a Gemfile.lock due to bundler-ception issues. we also do not want to read and pin the version of bundler which is used to BUILD the lockfile since that isn't necessarily the bundler version which omnibus will install. but once we're done we can force-activate bundler to resolve any possible unresolved spec. eventually we could be mildly smarter here if we need to and only do this if ther are unresolved specs and if the unresolved spec is bundler, but doing it all the time should be simple+safe. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after we've activated all the other gems, force bundler activation.
since we're appbundling we've already activated all the gems and have
all the constraints loaded. but bundler will not put bundler in a
Gemfile.lock due to bundler-ception issues. we also do not want to
read and pin the version of bundler which is used to BUILD the lockfile
since that isn't necessarily the bundler version which omnibus will
install.
but once we're done we can force-activate bundler to resolve any
possible unresolved spec.
eventually we could be mildly smarter here if we need to and only do
this if ther are unresolved specs and if the unresolved spec is
bundler, but doing it all the time should be simple+safe.
(and since we've always installed bundler and bundler is in ruby now i can't see how activating it would go wrong here....)