Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant public key file could be empty #258

Closed
indigo423 opened this issue Aug 25, 2014 · 3 comments
Closed

Vagrant public key file could be empty #258

indigo423 opened this issue Aug 25, 2014 · 3 comments

Comments

@indigo423
Copy link

It could be possible the wget command runs in an error and creates an empty authorized_keys file. The exit code is 0 and doesn't stop the build process. See example below by having issues resolving the raw.githubusercontent.com address:

Provisioning with shell script: scripts/common/vagrant.sh
virtualbox-iso: --2014-08-25 10:18:06--  https://raw.githubusercontent.com/mitchellh/vagrant/master/keys/vagrant.pub
virtualbox-iso:   Resolving raw.githubusercontent.com... failed: Name or service not known.
virtualbox-iso: wget: unable to resolve host address "raw.githubusercontent.com"
virtualbox-iso: Provisioning with shell script: scripts/common/vmtools.sh
virtualbox-iso: Verifying archive integrity... All good.

Suggestion to solve this issue: #257

@juliandunn
Copy link
Contributor

According to the wget man page, it should return non-zero when an error occurs. How about just testing for that in the script?

@juliandunn
Copy link
Contributor

@indigo423 are you still working on this or shall I close it?

@cheeseplus
Copy link
Contributor

Resolved by 51b7643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants