Guard for empty vagrant authorized_keys file #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be possible the `wget` command runs in an error and creates an empty `authorized_keys` file. The exit code is 0 and doesn't stop the build process. See example below by having issues resolving the raw.githubusercontent.com address:
Provisioning with shell script: scripts/common/vagrant.sh
virtualbox-iso: --2014-08-25 10:18:06-- https://raw.githubusercontent.com/mitchellh/vagrant/master/keys/vagrant.pub
virtualbox-iso: Resolving raw.githubusercontent.com... failed: Name or service not known.
virtualbox-iso: wget: unable to resolve host address "raw.githubusercontent.com"
virtualbox-iso: Provisioning with shell script: scripts/common/vmtools.sh
virtualbox-iso: Verifying archive integrity... All good.
|
See my comment on #258. |
|
So even though this should be something wget bubbles up I'm all for extra checks that don't cause anymore issues - could this be rebased? |
|
Can't merge this any longer so closing but will credit changes in new PR |
|
Oh wait looks like this was taken care of inadvertently by another commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be possible the
wgetcommand runs in an error and creates an emptyauthorized_keysfile. The exit code is 0 and doesn't stop the build process. See example below by having issues resolving the raw.githubusercontent.com address: