Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debian cleanup script removes C/C++ compiler and therefore breaks DKMS support #509

Closed
RobertDeRose opened this issue Dec 18, 2015 · 1 comment · Fixed by #510
Closed

Debian cleanup script removes C/C++ compiler and therefore breaks DKMS support #509

RobertDeRose opened this issue Dec 18, 2015 · 1 comment · Fixed by #510

Comments

@RobertDeRose
Copy link

Is this intentional?

This line:

bento/scripts/debian/cleanup.sh

Line 31 in 52a13b5

apt-get -y purge cpp gcc g++;

And similarly for Ubuntu

bento/scripts/ubuntu/cleanup.sh

Line 31 in 52a13b5

apt-get -y purge cpp gcc g++;

This doesn't seem like you'd want this. Why install DKMS in the preseed in the first place if you don't need it? or is installing DKMS just a faster way to get everything installed that the Guest Additions require?

If it is not the desired intent, I'd like to submit a PR to remove these lines, someone might need to inspect the other distros as well.
@RobertDeRose
Copy link
Author

Additional note. DKMS package is removed because of the apt-get -y purge command.

RobertDeRose pushed a commit to RobertDeRose/bento that referenced this issue Dec 18, 2015
Stops DKMS package from being removed.
ebea21f 
DKMS is needed to recompile the guest additions if a new kernel
is installed.  Removing the C/C++ packages also removes the `dkms`
package.  This fixes chef#509 for Dedian based distros.
@RobertDeRose RobertDeRose mentioned this issue Dec 18, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stops DKMS package from being removed. RobertDeRose/bento
1 participant
@RobertDeRose