Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CentOS Stream 9 (x86_64) template #1444

Merged
merged 1 commit into from
Dec 18, 2022

Conversation

carlosefr
Copy link
Contributor

@carlosefr carlosefr commented Dec 11, 2022

Description

This PR adds a new template for CentOS Stream 9 (x86_64). I've tested building it locally with packer 1.8.4 and VirtualBox 7.0.4 (it requires the latter due to older guest addons not supporting the latest CentOS 9.x kernel).

Related Issue

#1391

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Carlos Rodrigues <cefrodrigues@gmail.com>
@carlosefr carlosefr requested review from a team as code owners December 11, 2022 16:06
@tas50
Copy link
Contributor

tas50 commented Dec 12, 2022

@carlosefr Have you gotten this to fully build? I tried to build it tonight so I could push it up, but it fails compiling the vbox tools.

@carlosefr
Copy link
Contributor Author

@carlosefr Have you gotten this to fully build? I tried to build it tonight so I could push it up, but it fails compiling the vbox tools.

I did, but only with VirtualBox 7.0.4. From its changelog, older guest additions may not work with CentOS Stream 9's kernel (and I haven't seen a new VirtualBox 6.x with this in the changelog either).

Stromweld
Stromweld previously approved these changes Dec 12, 2022
Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosefr
Copy link
Contributor Author

Since this requires VirtualBox 7.0.4 because of the guest additions, I should probably re-add the vboxmanage command I removed with 58e2498.

@tas50
Copy link
Contributor

tas50 commented Dec 16, 2022

Yeah sorry we probably need it back

@carlosefr carlosefr force-pushed the carlosefr/centos_stream_9 branch from 58e2498 to f244ff1 Compare December 17, 2022 20:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks

@Stromweld Stromweld merged commit 55607b6 into chef:main Dec 18, 2022
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants