Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rectify typo for amazonlinux in locals data structure comparison test #1472

Merged

Conversation

campfield
Copy link
Contributor

Signed-off-by: Michael Campfield michael.campfield@mailbox.org

Description

In the locals data structure there is a string misspelling which is part of a value equality conditional test.

The lefthand of the comparison operation is an equality test against the string 'amazonlinux-2' . However, the string amazonlinux-2 has a character addition typo with a 'u' added between the i and n of linux: amazonliunux-2.

Rectifying this issue will cause the value test against amazonlinux-2 to evaluate correctly.

Types of changes

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • [X ] I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • [X ] All commits have been signed-off for the Developer Certificate of Origin.

Obvious fix.

@campfield campfield requested review from a team and Stromweld as code owners February 10, 2023 20:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@Stromweld Stromweld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@Stromweld Stromweld enabled auto-merge (squash) February 11, 2023 22:14
@Stromweld Stromweld merged commit db97314 into chef:main Feb 11, 2023
@campfield campfield deleted the rectify-typo-templates-builders-locals branch February 14, 2023 03:49
raykrist pushed a commit to norcams/bento that referenced this pull request Aug 19, 2024
Co-authored-by: Michael Campfield <campfieldm@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants