[macosx-*] Improve DRYness & correctness of Mac templates. #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following improvements are made in this commit:
template
user variable to replace repetition of"macosx-10.*"
style strings throughoutHOME_DIR
environment variable for provisioner scripts touse
default leading to less behavior "tuning knobs" in the templates
arch
andautologin
_README
user variable to explain how to obtain andprepare the base disk image
"macosx-10.*"
to"chef/macosx-10.*"
iso_checksum_type
into a user variable and reference itin the templates
sh -eux
which will: (e) exitimmediately if a command exists with a non-zero exit status, (u)
treats unset variables as a error, and (x) outputs the command and its
expanded arguments or associated word list
bourne shell friendly
vmware-tools-cli disk shrink
command inscripts/macosx/minimize.sh
if the provider is vmware-based