Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored vmware tools scripts #638

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Refactored vmware tools scripts #638

merged 1 commit into from
Sep 8, 2016

Conversation

svpace
Copy link
Contributor

@svpace svpace commented Jul 28, 2016

Update Centos 7 to use OVT and refactored the scripts structure to make it easier to include new distributions. #600 #621

@cheeseplus
Copy link
Contributor

cheeseplus commented Jul 28, 2016

I don't see scripts/centos/vmware.sh which was added being called in the PR. Also this only address VMware which is fine for the moment but we should really abstract all of them or not at all.

vmware-iso|vmware-vmx)
apt-get install -y open-vm-tools;
mkdir /mnt/hgfs;
echo "platform specific vmware.sh executed";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is indented unnecessarily

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Fixed it.

@cheeseplus
Copy link
Contributor

Now that I've got 2.2.9 out the door I can look at testing this across all the providers.

@svpace
Copy link
Contributor Author

svpace commented Aug 31, 2016

Hi @cheeseplus, did you had the chance to test this one up?

@cheeseplus
Copy link
Contributor

Let's get this in and see how we do.

@mvermaes
Copy link
Contributor

Are there any specific host requirements to use this? I tried to build a CentOS 7.2 template incorporating this pull request but the guest is unable to access shared folders, eventually timing out with:

HGFS was never found on the running virtual machine. This must be
installed either through VMware tools or Open VM Tools. HGFS is
required for shared folders to work properly. Please install either
the VMware tools or Open VM Tools and try again.

@cheeseplus
Copy link
Contributor

Doesn't look like this helps for CentOS platforms as there is no HGFS distributed with open-vm-tools so that makes 99% of the reason why we'd use it moot :(

See: #667 (comment)

cheeseplus pushed a commit that referenced this pull request Sep 29, 2016
cheeseplus pushed a commit that referenced this pull request Sep 29, 2016
@svpace
Copy link
Contributor Author

svpace commented Oct 5, 2016

Indeed, AFAIK HGFS will only be available when the CentOS team upgrades to OVT 10. I don't use the shared folders feature that much since it is not something I would have in production (i'm a rsync guy myself :) but I imagine that I may be the exception in this case.

Nonetheless, what do you think about a variable to control this behavior? So we can use the variable file to select between OVT and VMT boxes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants