Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure /etc/sudoers sed replacement works for Debian 7.x. #73

Merged
merged 1 commit into from
Aug 30, 2013
Merged

Ensure /etc/sudoers sed replacement works for Debian 7.x. #73

merged 1 commit into from
Aug 30, 2013

Conversation

justsee
Copy link
Contributor

@justsee justsee commented Aug 17, 2013

Debian 7's /etc/sudoers file format has changed, requiring an update to the sed regex in the sudoers.sh script.

As this is only specific to this definition, I've removed the symlink to the common debian/sudoers.sh and created a new sudoers.sh file with the required updates.

@juliandunn
Copy link
Contributor

Hi @justsee!

Thank you for supporting an Opscode project! Our process has a couple prerequisites before we can merge your contribution. We need to ensure you've completed a Contributor License Agreement (CLA) and a ticket on our ticket tracker for the release workflow. Pull requests are optional, but should always include the ticket number that they're related to for cross-referencing. Please take a moment to review the below wiki page for the appropriate steps:

http://wiki.opscode.com/display/chef/How+to+Contribute
http://wiki.opscode.com/display/chef/Code+Review

If you already have signed a CLA, can you please create a JIRA ticket at tickets.opscode.com and set it to "Fix Provided" referencing this PR?

Thanks
Julian

@micxer
Copy link

micxer commented Aug 29, 2013

Is this the reason why vagrant isn't able to set the hostname anymore? I just stumbled upon this issue: https://gist.github.com/micxer/451e8727d21a0989d860.

What I don't understand is, that it was working a couple of days ago when I downloaded the base box for Debian 7.1.0. Today I had to download it again and it just stopped working with the aforementioned error.

@justsee
Copy link
Contributor Author

justsee commented Aug 29, 2013

Yes, the common sudoers.sh does not correctly format NOPASSWD in /etc/sudoers for vagrant. So any bootstrapping commands with sudo will fail with the Stderr shown in your gist output.

@mattray
Copy link

mattray commented Aug 30, 2013

@micxer the previous image was broken with BENTO-82, where the CDROM was still in the sources. Now it's broken because the vagrant user isn't in sudoers. @justsee if you've got a CLA we can merge and push this out ASAP.

@justsee
Copy link
Contributor Author

justsee commented Aug 30, 2013

@mattray I submitted the CLA a few hours ago, so it should be fine to merge.

@micxer
Copy link

micxer commented Aug 30, 2013

@mattray that was actually the reason why I redownloaded the box :-) I was hoping that this was already fixed. Looking forward to the working version so I can throw away my custom base box.

juliandunn added a commit that referenced this pull request Aug 30, 2013
Ensure /etc/sudoers sed replacement works for Debian 7.x.
@juliandunn juliandunn merged commit b259387 into chef:master Aug 30, 2013
@justsee justsee deleted the fix-debian-7-sudoers branch August 31, 2013 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants