Do not return 400 for valid /users/USERNAME/_acl/PERM calls #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevendanna
commented
Apr 26, 2017
| @@ -238,6 +236,14 @@ extract_full_names(ScopedNames, UnscopedNameSet) -> | |||
| %% Abstract away difference in lookups between actors, clients, users and groups. | |||
| %% | |||
| %% Returns AuthzIds, missing names and names that are judged ambiguous | |||
| %% | |||
|
|
|||
| %% The first two function heads are to account of this being called from a global context | |||
There was a problem hiding this comment.
Typo: "account of this" -> "account for this being"
marcparadise
approved these changes
Apr 27, 2017
jaymalasinha
pushed a commit
to chef/chef-zero
that referenced
this pull request
Apr 27, 2017
as the user acls are not currently supported here Related to chef/chef-server#1242 Signed-off-by: Jaymala Sinha <jsinha@chef.io>
|
@stevendanna I added this commit to disable user acl tests for chef-zero. Paired with @marcparadise on this |
jaymalasinha
pushed a commit
to chef/chef-zero
that referenced
this pull request
Apr 27, 2017
as the user acls are not currently supported here Related to chef/chef-server#1242 Signed-off-by: Jaymala Sinha <jsinha@chef.io>
Previously, if PUT was made to update a user ACL, the request would return 400 if the request body contained a user. This was because the code expected an OrgId to be set. Now, we assume that requests in the global context (no org id), can only refer to users. An alternative approach would be to extend the implementation of the new scoping syntax so that it works everywhere. A number of disabled pedant tests have been re-enabled. Signed-off-by: Steven Danna <steve@chef.io>
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if PUT was made to update a user ACL, the request would
return 400 if the request body contained a user. This was because the
code expected an OrgId to be set. Now, we assume that requests in the
global context (no org id), can only refer to users.
An alternative approach would be to extend the implementation of the
new scoping syntax so that it works everywhere.
A number of disabled pedant tests have been re-enabled.
Signed-off-by: Steven Danna steve@chef.io