Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launcher:(script) remove nounset option #160

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

afiune
Copy link

@afiune afiune commented Feb 11, 2020

Description

When running this script with su we have an error message:

Salims-MBP:~ root# su "$SUDO_USER" /opt/chef-workstation/bin/chef_workstation_app_launcher load
/opt/chef-workstation/bin/chef_workstation_app_launcher:set:20: no such option: u

Removing the -u option seems to work just fine.

Salims-MBP:~ root# su "$SUDO_USER" /opt/chef-workstation/bin/chef_workstation_app_launcher load
Salims-MBP:~ root# su "$SUDO_USER" /opt/chef-workstation/bin/chef_workstation_app_launcher show
{
	"LimitLoadToSessionType" = "Aqua";
	"MachServices" = {
		"sh.chef.chef-workstation.MachPortRendezvousServer.22512" = mach-port-object;
	};
	"Label" = "io.chef.chef-workstation.app";
	"TimeOut" = 30;
	"OnDemand" = true;
	"LastExitStatus" = 0;
	"PID" = 22512;
	"Program" = "/Applications/Chef Workstation App.app/Contents/MacOS/Chef Workstation App";
	"ProgramArguments" = (
		"/Applications/Chef Workstation App.app/Contents/MacOS/Chef Workstation App";
	);
	"PerJobMachServices" = {
		"com.apple.tsm.portname" = mach-port-object;
		"com.apple.coredrag" = mach-port-object;
		"com.apple.axserver" = mach-port-object;
	};
};

Signed-off-by: Salim Afiune afiune@chef.io

Related Issue

chef/chef-workstation#938

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

When running this script with `su` we have an error message:
```
/opt/chef-workstation/bin/chef_workstation_app_launcher:set:20: no such option: u
```

Removing this option seems to work just fine.

Signed-off-by: Salim Afiune <afiune@chef.io>
@afiune afiune requested review from a team February 11, 2020 21:16
@afiune afiune self-assigned this Feb 11, 2020
@afiune afiune added the Type: Bug Does not work as expected. label Feb 11, 2020
Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afiune afiune merged commit 2350b5d into master Feb 11, 2020
@chef-expeditor chef-expeditor bot deleted the afiune/remove-nounset branch February 11, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Does not work as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants