Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to a supported nokogiri release #1321

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Switch back to a supported nokogiri release #1321

merged 2 commits into from
Jul 10, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jul 6, 2020 •
edited by jonsmorrow
Loading

Nokogiri 1.10.10 shipped this week and it adds Ruby 2.7 binaries for
Windows. This allows us to get of the beta release and back onto a
supported stable release.

Signed-off-by: Tim Smith tsmith@chef.io

Aha! Link: https://chef.aha.io/features/SH-2517

@tas50 tas50 requested review from a team as code owners July 6, 2020 16:15
@netlify
Copy link

netlify bot commented Jul 6, 2020 •
edited
Loading

Deploy preview for chef-workstation ready!

Built with commit daf8cc1

https://deploy-preview-1321--chef-workstation.netlify.app

tyler-ball
tyler-ball approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running an ad-hoc: https://buildkite.com/chef/chef-chef-workstation-master-omnibus-adhoc/builds/315

If that passes lets :shipit:

@tyler-ball
Copy link
Contributor

tyler-ball commented Jul 9, 2020 •
edited
Loading

Failed

Traceback (most recent call last):
--
  | 5: from /usr/bin/chef-cli:207:in `<main>'
  | 4: from /opt/chef-workstation/embedded/lib/ruby/2.7.0/rubygems/core_ext/kernel_gem.rb:68:in `gem'
  | 3: from /opt/chef-workstation/embedded/lib/ruby/2.7.0/rubygems/core_ext/kernel_gem.rb:68:in `synchronize'
  | 2: from /opt/chef-workstation/embedded/lib/ruby/2.7.0/rubygems/core_ext/kernel_gem.rb:68:in `block in gem'
  | 1: from /opt/chef-workstation/embedded/lib/ruby/2.7.0/rubygems/specification.rb:1367:in `activate'
  | /opt/chef-workstation/embedded/lib/ruby/2.7.0/rubygems/specification.rb:2233:in `check_version_conflict': can't activate mini_portile2-2.4.0, already activated mini_portile2-2.5.0 (Gem::LoadError)

@tas50
Copy link
Contributor Author

tas50 commented Jul 9, 2020

Yeah that's super odd

tas50 and others added 2 commits July 10, 2020 12:41
@tas50 @tyler-ball
Switch back to a supported nokogiri release
905ec2e 
Nokogiri 1.10.10 shipped this week and it adds Ruby 2.7 binaries for
Windows. This allows us to get of the beta release and back onto a
supported stable release.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tyler-ball
No longer need to uninstall/install nokogiri to force compilation
daf8cc1 
We are reverting to 1.10 which does not have the pre-built linux binary,
so we do not need to force `--platform ruby` in the nokogiri gem
install.

Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball merged commit 6da4471 into master Jul 10, 2020
@chef-expeditor chef-expeditor bot deleted the nokogiri branch July 10, 2020 21:34
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-ball tyler-ball tyler-ball approved these changes

Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tas50 @tyler-ball @jonsmorrow