Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After removing the /usr/local symlink we need to chef exec our test so it finds the utility in embedded/bin #1464

Merged
merged 3 commits into from
Sep 3, 2020

Conversation

tyler-ball
Copy link
Contributor

@tyler-ball tyler-ball commented Sep 3, 2020

Description

Also cleaning up how we update our chef-web-docs submodule to ensure it doesn't get downgraded again

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

…o it finds the utility in embedded/bin

Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball requested review from a team as code owners September 3, 2020 18:21
@netlify
Copy link

netlify bot commented Sep 3, 2020

Deploy preview for chef-workstation ready!

Built with commit ced3af9

https://deploy-preview-1464--chef-workstation.netlify.app

In #1462 our
chef-web-docs folder accidently got downgraded to a super old version,
which was causing build failures. This Makefile change ensures we always
have the latest version of the chef-web-docs submodule when building.

Signed-off-by: tyler-ball <tball@chef.io>
Signed-off-by: tyler-ball <tball@chef.io>
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks considerably more correct!

@tyler-ball tyler-ball merged commit 12c2ef5 into master Sep 3, 2020
@tyler-ball tyler-ball deleted the fix_release_test branch September 3, 2020 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants