Add taskkill action to windows install #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
force-pushed
the
mp/ensure-win-proc-killed-on-install
branch
from
7f776dd
to
78f758b
Compare
cheeseplus
approved these changes
Sep 27, 2018
marcparadise
force-pushed
the
mp/ensure-win-proc-killed-on-install
branch
from
78f758b
to
fbe35da
Compare
tyler-ball
force-pushed
the
mp/ensure-win-proc-killed-on-install
branch
from
fbe35da
to
e8c5a5f
Compare
|
@marcparadise I updated this to follow something similar to https://stackoverflow.com/questions/11439767/how-to-kill-a-process-from-wix - just tested it and it looks good! Correctly closed CWA when trying to do a new install |
tyler-ball
approved these changes
Oct 1, 2018
This adds a 'taskkill' of 'Chef Workstation App.exe' after the installer initializes. This will prevent installations from failing because the tray app executable is in use and can't be replaced. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com> Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
mp/ensure-win-proc-killed-on-install
branch
from
e8c5a5f
to
a028a45
Compare
jonsmorrow
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a 'taskkill' of 'Chef Workstation App.exe'
after the installer initializes. This will prevent installations
from failing because the tray app executable is in use and
can't be replaced.
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com
Check List
www/site/content/docs/has been updated with any relevant changes