Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHACK-357] Include latest stable release of ChefDK #247

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

tyler-ball
Copy link
Contributor

@tyler-ball tyler-ball commented Sep 28, 2018

Description

Expeditor will manage the pinned version for us. Whenever ChefDK is released it will update the omnibus pin.

Issues Resolved

SHACK-357

Check List

  • PR title is a worthy inclusion in the CHANGELOG
  • You have locally validated the change
  • www/site/content/docs/ has been updated with any relevant changes:
      • new or changed error messages in 'troubleshooting.md'
      • new or changed CLI flags in cli-reference.md

Signed-off-by: tyler-ball tball@chef.io

@tyler-ball tyler-ball requested a review from a team September 28, 2018 15:49
@tyler-ball tyler-ball force-pushed the SHACK-357/pin branch 2 times, most recently from b517830 to 53dbae2 Compare September 28, 2018 15:53
Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyler-ball
Copy link
Contributor Author

@marcparadise @jonsmorrow I updated the logic in here to have expeditor manage the pinned ChefDK version, rather than pulling it from Omnitruck at build time. Could use a re-review!

Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Expeditor will manage the pinned version for us. Whenever ChefDK is
released it will update the omnibus pin.

Signed-off-by: tyler-ball <tball@chef.io>
@tyler-ball tyler-ball merged commit f79b98a into master Oct 1, 2018
@tyler-ball tyler-ball deleted the SHACK-357/pin branch October 1, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants