Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed condition for CWA lib detection #266

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

marcparadise
Copy link
Member

Signed-off-by: Marc A. Paradise marc.paradise@gmail.com

Description

This corrects a reversed postinst conditional that would cause the package install to tell the user that they could run chef-workstation-app when there were still deps to install.

Check List

  • PR title is a worthy inclusion in the CHANGELOG
  • You have locally validated the change

@marcparadise marcparadise requested a review from a team October 12, 2018 19:09
Copy link
Contributor

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only off by one, so close

@marcparadise
Copy link
Member Author

Added do-not-merge, I want to do some more testing of this.

Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
@marcparadise marcparadise force-pushed the mp/fix-postinst-lib-detection-linux branch from 74cea59 to 4b6f1d5 Compare October 16, 2018 15:53
@marcparadise marcparadise merged commit c44ad2a into master Oct 16, 2018
@chef-ci chef-ci deleted the mp/fix-postinst-lib-detection-linux branch October 16, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants