Bug fixes #38
Merged
Bug fixes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got approval from @tduffield that we can merge this despite the expeditor 'failure' |
marcparadise
approved these changes
Mar 30, 2018
This fixes two issues: First, during demos I discovered that if the remote command failed but did so before chef was invoked, we could end up getting a stale chef stacktrace copied over. So now we delete the chef stacktrace after we copy it to the workstation - this prevents copying over an old, stale stacktrace and hindering bug troubleshooting. Second, we were trying to output some terminal information before initializing the terminal (in the scenario where a config file has not yet been created).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
First, during demos I discovered that if the remote command failed but did so before chef was invoked, we could end up getting a stale chef stacktrace copied over. So now we delete the chef stacktrace after we copy it to the workstation - this prevents copying over an old, stale stacktrace and hindering bug troubleshooting.
Second, we were trying to output some terminal information before initializing the terminal (in the scenario where a config file has not yet been created).