Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in PATH /opt/chefworkstation -> /opt/chef-workstation #567

Conversation

ls-brentsmith
Copy link
Contributor

@ls-brentsmith ls-brentsmith commented Oct 7, 2019

Signed-off-by: Brent Smith brent.smith@lightspeedhq.com

Description

Binaries were not executable without specifying their entire path.

:➜  ~ docker run --rm -it chef/chefworkstation which bundle
:➜  ~ docker run --rm -it chef/chefworkstation:issue564 which bundle
/opt/chef-workstation/embedded/bin/bundle

Related Issue

Fixes #564

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • [ x] I have read the CONTRIBUTING document.
  • [x ] I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • [x ] All new and existing tests passed.
  • [x ] All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: Brent Smith <brent.smith@lightspeedhq.com>
@ls-brentsmith ls-brentsmith requested review from a team as code owners October 7, 2019 23:06
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ls-brentsmith for fixing this!

@tyler-ball tyler-ball merged commit be2bb78 into chef:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile sets PATH incorrectly
2 participants