Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup additional files / folders in the installed gems #714

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Cleanup additional files / folders in the installed gems #714

merged 1 commit into from
Nov 14, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Nov 14, 2019

This slims the install by 241k on disk and 28 files.

Signed-off-by: Tim Smith tsmith@chef.io

@tas50
Cleanup additional files / folders in the installed gems
e9c3fbe 
This slims the install by 241k on disk and 28 files.

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners November 14, 2019 00:08
jonsmorrow
jonsmorrow approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

I'd love to see us clean test out also. I wonder if we could whitelist the few gems we need it to stay?

@tas50
Copy link
Contributor Author

tas50 commented Nov 14, 2019

Cleaning the tests is the next thing and that's going to have to be a bit more surgical

@tas50 tas50 added Expeditor: Skip Habitat Used to skip built_in:trigger_habitat_package_build Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build labels Nov 14, 2019
@tas50 tas50 merged commit 99ddd65 into master Nov 14, 2019
@chef-expeditor chef-expeditor bot deleted the more_slim branch November 14, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsmorrow jonsmorrow jonsmorrow approved these changes

Assignees
No one assigned
Labels
Expeditor: Skip Habitat Used to skip built_in:trigger_habitat_package_build Expeditor: Skip Omnibus Used to skip built_in:trigger_omnibus_release_build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tas50 @jonsmorrow