[SHACK-155] cli integration tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcparadise
force-pushed
the
SHACK-155/cli-integration-tests
branch
2 times, most recently
from
9a11287
to
e07b97b
Compare
|
The current test failures are because output contains workstation-specific paths. Looking for ways around that monday morning. Edit: This is fixed now |
marcparadise
force-pushed
the
SHACK-155/cli-integration-tests
branch
from
470c1fb
to
1531773
Compare
tyler-ball
approved these changes
Apr 20, 2018
| if @argv[0].casecmp("help") == 0 | ||
| # Special case for prefixed --help/-h: we have to move it to the end so that | ||
| # we don't consider '-h' to be the command we're trying to load. | ||
| if @argv[0].casecmp("help") == 0 || @argv[0] == "-h" || @argv[0] == "--help" |
There was a problem hiding this comment.
if %w{help -h --help}.include?(@argv[0].downcase)
| @@ -35,13 +35,13 @@ class Base | |||
| option :version, | |||
| :short => "-v", | |||
| :long => "--version", | |||
| :description => T.version, | |||
| :description => Text.commands.version.description, | |||
There was a problem hiding this comment.
Yeah, where these are not super long I think we don't need to obfuscate with the T reference. I think this (4 levels) is about as long as I am comfortable with
| @@ -0,0 +1,21 @@ | |||
| Chef Workstation Version: 0.1.53 | |||
tyler-ball
force-pushed
the
SHACK-155/cli-integration-tests
branch
from
1531773
to
e349339
Compare
|
@marcparadise I fixed the minor things I found, rebased and squashed what looked like minor commits to me |
|
👍 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spiked an aruba this morning, and couldn't get it to actually execute the features - it was giving me an internal exception about wrong number of arguments while modeling a test on the example. Rather than continue to shave that yak, I used rspec with a couple of minor helper functions. For what we're doing - looking at complete output of given command - this will work for now. If our needs change, we can revisit it later.
This PR contains the tests themselves, and several minor fixes for issues uncovered while running them.
Future tests will be added individually along with any required fixes.