Skip to content

Commit

Permalink
Merge pull request #296 from chef/relative
Browse files Browse the repository at this point in the history
Substitute require for require_relative
  • Loading branch information
tas50 authored Dec 30, 2019
2 parents 7c856ba + 30dc4f1 commit b39025e
Show file tree
Hide file tree
Showing 96 changed files with 321 additions and 233 deletions.
5 changes: 5 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Order is important. The last matching pattern has the most precedence.

* @chef/chef-foundation-owners @chef/chef-foundation-approvers @chef/chef-foundation-reviewers
.expeditor/ @chef/jex-team
*.md @chef/docs-team
29 changes: 29 additions & 0 deletions .github/ISSUE_TEMPLATE/BUG_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
---
name: � Bug Report
about: If something isn't working as expected �.
labels: "Status: Untriaged, Type: Bug"
---

# Version:

[Version of the project installed]

# Environment:

[Details about the environment such as the Operating System, cookbook details, etc...]

# Scenario:

[What you are trying to achieve and you can't?]

# Steps to Reproduce:

[If you are filing an issue what are the things we need to do in order to repro your problem?]

# Expected Result:

[What are you expecting to happen as the consequence of above reproduction steps?]

# Actual Result:

[What actually happens after the reproduction steps?]
40 changes: 40 additions & 0 deletions .github/ISSUE_TEMPLATE/DESIGN_PROPOSAL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
---
name: Design Proposal
about: I have a significant change I would like to propose and discuss before starting
labels: "Status: Untriaged, Type: Design Proposal"
---

### When a Change Needs a Design Proposal

A design proposal should be opened any time a change meets one of the following qualifications:

- Significantly changes the user experience of a project in a way that impacts users.
- Significantly changes the underlying architecture of the project in a way that impacts other developers.
- Changes the development or testing process of the project such as a change of CI systems or test frameworks.

### Why We Use This Process

- Allows all interested parties (including any community member) to discuss large impact changes to a project.
- Serves as a durable paper trail for discussions regarding project architecture.
- Forces design discussions to occur before PRs are created.
- Reduces PR refactoring and rejected PRs.

---

<!--- Proposal description and rationale. -->

## Motivation

<!---
As a <<user_profile>>,
I want to <<functionality>>,
so that <<benefit>>.
-->

## Specification

<!--- A detailed description of the planned implementation. -->

## Downstream Impact

<!--- Which other tools will be impacted by this work? -->
17 changes: 17 additions & 0 deletions .github/ISSUE_TEMPLATE/ENHANCEMENT_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
name: 🚀 Enhancement Request
about: I have a suggestion (and may want to implement it 🙂)!
labels: "Status: Untriaged"
---

### Describe the Enhancement:
<!--- What you are trying to achieve that you can't? -->

### Describe the Need:
<!--- What kind of user do you believe would utilize this enhancement, and how many users might want this functionality -->

### Current Alternative
<!--- Is there a current alternative that you can utilize to workaround the lack of this enhancement -->

### Can We Help You Implement This?:
<!--- The best way to ensure your enhancement is built is to help implement the enhancement yourself. If you're interested in helping out we'd love to give you a hand to make this possible. Let us know if there's something you need. -->
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/SUPPORT_QUESTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
name: 🤗 Support Question
about: If you have a question 💬, please check out our Slack!
---

We use GitHub issues to track bugs and feature requests. If you need help please post to our Mailing List or join the Chef Community Slack.

* Chef Community Slack at http://community-slack.chef.io/.
* Chef Mailing List https://discourse.chef.io/

Support issues opened here will be closed and redirected to Slack or Discourse.
14 changes: 0 additions & 14 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,6 @@ branches:
only:
- master

# Early warning system to catch if Rubygems breaks something
before_install:
- gem update --system
- gem install bundler

language: ruby
cache: bundler
bundler_args: --jobs 7 --without debug
Expand All @@ -31,12 +26,3 @@ matrix:
- rvm: 2.5.3
script: bundle exec rake chef_spec
env: TEST=chef_spec
- rvm: 2.5.3
script: bundle exec rake spec
env: TEST=rake_spec
- rvm: 2.4.5
script: bundle exec rake spec
env: TEST=rake_spec
- rvm: 2.5.3
script: bundle exec rake style
env: TEST=chefstyle
2 changes: 1 addition & 1 deletion lib/chef_zero.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module ChefZero
require "chef_zero/log"
require_relative "chef_zero/log"

MIN_API_VERSION = 0
MAX_API_VERSION = 2
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/chef_data/data_normalizer.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "chef_zero"
require "chef_zero/rest_base"
require "chef_zero/chef_data/default_creator"
require_relative "../../chef_zero"
require_relative "../rest_base"
require_relative "default_creator"

module ChefZero
module ChefData
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/chef_data/default_creator.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/chef_data/acl_path"
require_relative "acl_path"

module ChefZero
module ChefData
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/data_store/data_already_exists_error.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# limitations under the License.
#

require "chef_zero/data_store/data_error"
require_relative "data_error"

module ChefZero
module DataStore
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/data_store/data_not_found_error.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# limitations under the License.
#

require "chef_zero/data_store/data_error"
require_relative "data_error"

module ChefZero
module DataStore
Expand Down
4 changes: 2 additions & 2 deletions lib/chef_zero/data_store/default_facade.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require "chef_zero/data_store/interface_v2"
require "chef_zero/chef_data/default_creator"
require_relative "interface_v2"
require_relative "../chef_data/default_creator"

module ChefZero
module DataStore
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/data_store/interface_v2.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/data_store/interface_v1"
require_relative "interface_v1"

module ChefZero
module DataStore
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/data_store/memory_store.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
# limitations under the License.
#

require "chef_zero/data_store/v2_to_v1_adapter"
require "chef_zero/data_store/memory_store_v2"
require "chef_zero/data_store/default_facade"
require_relative "v2_to_v1_adapter"
require_relative "memory_store_v2"
require_relative "default_facade"

module ChefZero
module DataStore
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/data_store/memory_store_v2.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
# limitations under the License.
#

require "chef_zero/data_store/data_already_exists_error"
require "chef_zero/data_store/data_not_found_error"
require "chef_zero/data_store/interface_v2"
require_relative "data_already_exists_error"
require_relative "data_not_found_error"
require_relative "interface_v2"

module ChefZero
module DataStore
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/data_store/raw_file_store.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@
# limitations under the License.
#

require "chef_zero/data_store/data_already_exists_error"
require "chef_zero/data_store/data_not_found_error"
require "chef_zero/data_store/interface_v2"
require_relative "data_already_exists_error"
require_relative "data_not_found_error"
require_relative "interface_v2"
require "fileutils"

module ChefZero
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/data_store/v1_to_v2_adapter.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/data_store/interface_v2"
require_relative "interface_v2"

module ChefZero
module DataStore
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/data_store/v2_to_v1_adapter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
# limitations under the License.
#

require "chef_zero/data_store/interface_v1"
require_relative "interface_v1"

module ChefZero
module DataStore
Expand Down
4 changes: 2 additions & 2 deletions lib/chef_zero/endpoints/acl_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "ffi_yajl"
require "chef_zero/rest_base"
require "chef_zero/chef_data/acl_path"
require_relative "../rest_base"
require_relative "../chef_data/acl_path"

module ChefZero
module Endpoints
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/endpoints/acls_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "ffi_yajl"
require "chef_zero/rest_base"
require "chef_zero/chef_data/data_normalizer"
require "chef_zero/chef_data/acl_path"
require_relative "../rest_base"
require_relative "../chef_data/data_normalizer"
require_relative "../chef_data/acl_path"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/actor_default_key_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/rest_base"
require_relative "../rest_base"

module ChefZero
module Endpoints
Expand Down
4 changes: 2 additions & 2 deletions lib/chef_zero/endpoints/actor_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_object_endpoint"
require "chef_zero/chef_data/data_normalizer"
require_relative "rest_object_endpoint"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/actor_key_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/rest_base"
require_relative "../rest_base"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/actor_keys_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/rest_base"
require_relative "../rest_base"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/actors_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_list_endpoint"
require_relative "rest_list_endpoint"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/authenticate_user_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require "ffi_yajl"
require "chef_zero/rest_base"
require_relative "../rest_base"

module ChefZero
module Endpoints
Expand Down
4 changes: 2 additions & 2 deletions lib/chef_zero/endpoints/container_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_object_endpoint"
require "chef_zero/chef_data/data_normalizer"
require_relative "rest_object_endpoint"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/containers_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_list_endpoint"
require_relative "rest_list_endpoint"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/controls_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/dist"
require_relative "../dist"
module ChefZero
module Endpoints
# /organizations/ORG/controls
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/cookbook_artifact_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/chef_data/data_normalizer"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/chef_data/data_normalizer"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/cookbook_artifacts_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/chef_data/data_normalizer"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/cookbook_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/endpoints/cookbooks_base"
require_relative "cookbooks_base"

module ChefZero
module Endpoints
Expand Down
8 changes: 4 additions & 4 deletions lib/chef_zero/endpoints/cookbook_version_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_object_endpoint"
require "chef_zero/rest_error_response"
require "chef_zero/chef_data/data_normalizer"
require "chef_zero/data_store/data_not_found_error"
require_relative "rest_object_endpoint"
require_relative "../rest_error_response"
require_relative "../chef_data/data_normalizer"
require_relative "../data_store/data_not_found_error"

module ChefZero
module Endpoints
Expand Down
4 changes: 2 additions & 2 deletions lib/chef_zero/endpoints/cookbooks_base.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require "ffi_yajl"
require "chef_zero/rest_base"
require "chef_zero/chef_data/data_normalizer"
require_relative "../rest_base"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
2 changes: 1 addition & 1 deletion lib/chef_zero/endpoints/cookbooks_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
require "chef_zero/endpoints/cookbooks_base"
require_relative "cookbooks_base"

module ChefZero
module Endpoints
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/endpoints/data_bag_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_list_endpoint"
require "chef_zero/endpoints/data_bag_item_endpoint"
require "chef_zero/rest_error_response"
require_relative "rest_list_endpoint"
require_relative "data_bag_item_endpoint"
require_relative "../rest_error_response"

module ChefZero
module Endpoints
Expand Down
6 changes: 3 additions & 3 deletions lib/chef_zero/endpoints/data_bag_item_endpoint.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "ffi_yajl"
require "chef_zero/endpoints/rest_object_endpoint"
require "chef_zero/endpoints/data_bag_item_endpoint"
require "chef_zero/chef_data/data_normalizer"
require_relative "rest_object_endpoint"
require_relative "data_bag_item_endpoint"
require_relative "../chef_data/data_normalizer"

module ChefZero
module Endpoints
Expand Down
Loading

0 comments on commit b39025e

Please sign in to comment.