Partially Revert 1b2a6e5f107254cce8200a4750035b30265ae0c8 #120
Conversation
Currently, mounting the /users endpoint at the top level when in osc_compat mode causes errrors in the Chef integration tests. This may be due to a misconfiguration in the way Chef implements local mode but I am unable to pinpoint the exact causes right now. In any case, this is the minimal "revert" of 1b2a6e5 that gets Chef's integration tests working again.
|
Oh, @jaymzh that was your commit, can you help me understand what you wanted to accomplish? |
|
Those are the OSC URLs... OSC doesn't have organizations, users are a top-level thing... Seemed liked a bug, so I fixed when I was in there. It wasn't actually causing me a problems, so if I was wrong, I'm fine with this PR. |
|
In chef zero, all endpoints always have "organizations" to keep the endpoint logic simple. When you enable single org mode, it just enables a layer that tacks "/organizations/chef" onto any URLs the user hits. That's why you see "users" under an organization there, because in osc users are a top level thing and "/organizations/chef" is the top level :) Reverting is correct in this case. |
|
👍 |
|
Ok, thanks everyone, I'll merge. Seems like we would do well to get the pedant tests passing for the users endpoint so we can catch stuff like this in travis. |
danielsdeleo
deleted the
partial-revert-1b2a6e5f107254cce8200a4750035b30265ae0c8
branch
|
I looked for the code doing such a transmogrification but couldn't find it, I may have just been dense that day. Sorry for the bug. |
Currently, mounting the /users endpoint at the top level when in
osc_compat mode causes errrors in the Chef integration tests. This may
be due to a misconfiguration in the way Chef implements local mode but I
am unable to pinpoint the exact causes right now. In any case, this is
the minimal "revert" of 1b2a6e5 that
gets Chef's integration tests working again.
@jkeiser @chef/client-core