Update and refactor policy and policy_groups endpoints #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomcamel
force-pushed
the
jk/chef-fs-tests-plus-cd
branch
from
3f2702c
to
7ad8a34
Compare
|
LGTM 👍 |
| @@ -55,6 +55,11 @@ OptionParser.new do |opts| | |||
| options[:log_file] = value | |||
| end | |||
|
|
|||
| opts.on("--enterprise", "Whether to run in enterprise mode") do |value| | |||
There was a problem hiding this comment.
I realize this PR is just the chef-zero part, but will we need to push this config option up to chef-client -z?
There was a problem hiding this comment.
It's really a separate question. chef-client -z doesn't support full-on enterprise mode yet (there are separate PRs for that).
|
Can we uncomment the pedant policies test yet? Some questions, but overall 👍 |
|
@tyler-ball Not yet: those are the tests to skip for ChefFS, and that's PR chef/chef#4254, which depends on stuff in this PR, so this has to go first. |
randomcamel
changed the title
randomcamel
added a commit
that referenced
this pull request
Dec 8, 2015
Update and refactor policy and policy_groups endpoints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.