Implement APIv1 behaviors #201
Conversation
|
Have this PR up to fix test issue with ChefFS mode: chef/chef-server#753 |
|
|
||
| def get(request) | ||
| result = super | ||
| user_data = FFI_Yajl::Parser.parse(result[2], :create_additions => false) |
There was a problem hiding this comment.
FWIW RestBase defines parse_json and to_json helpers. (I discovered this too late for my last PR).
|
👍 |
|
@chef/client-dev-tools Ready for review. |
| if request.api_v0? | ||
| principal_data | ||
| else | ||
| { "principals" => [ principal_data ] } |
There was a problem hiding this comment.
If there is both a user and a client with the given name, should we return them both?
There was a problem hiding this comment.
Yeah, that's correct, according to my reading of the code here: https://github.com/chef/chef-server/blob/218579549024b26b3b97c9958503ff3651e3fb16/src/oc_erchef/apps/oc_chef_wm/src/chef_wm_named_principal.erl#L92-L102
OTOH, there's no pedant test for that, and it's an existing bug, and I probably won't have time to fix all that. So my inclination is to leave it as is until the problem comes up again.
|
@danielsdeleo one question, but looks good! |
|
👍 |
No description provided.