Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support URI specific character in file name #204

Merged
merged 1 commit into from
Jul 19, 2016
Merged

support URI specific character in file name #204

merged 1 commit into from
Jul 19, 2016

Conversation

byplayer
Copy link
Contributor

If file name includes URL meta characters, knife can't get that file.
So I add URI escape and decode for URI.

@byplayer byplayer mentioned this pull request Mar 10, 2016
Closed
@thommay
Copy link
Contributor

thommay commented Jul 18, 2016

👍 LGTM

@thommay thommay mentioned this pull request Jul 18, 2016
Closed
@thommay
Copy link
Contributor

thommay commented Jul 18, 2016

Fixes: chef/chef#3170

@smurawski
Copy link

👍

1 similar comment
@lamont-granquist
Copy link
Contributor

👍

@thommay thommay merged commit 903dd0f into chef:master Jul 19, 2016
@thommay thommay mentioned this pull request Jul 29, 2016
Closed
@thommay thommay added Type: Enhancement Adds new functionality. and removed enhancement labels Jan 24, 2017
@chef chef locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@byplayer @thommay @smurawski @lamont-granquist @tas50 @chef-supermarket