[chefstyle] import Chefstyle cops and config #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's already a lot of overlap with Chefstyle, and maintaining one repo instead of two makes development and maintenance easier for everyone. Adds --chefstyle argument, which uses chefstyle.yml instead of cookstyle.yml Didn't import Ruby27KeywordArgumentWarnings, since it's already in Cookstyle Signed-off-by: David Crosby <dcrosby@fb.com>
tpowell-progress
approved these changes
Jan 16, 2024
Signed-off-by: David Crosby <dcrosby@fb.com>
Signed-off-by: David Crosby <dcrosby@fb.com>
Signed-off-by: David Crosby <dcrosby@fb.com>
Signed-off-by: David Crosby <dcrosby@fb.com>
Signed-off-by: David Crosby <dcrosby@fb.com>
|
dafyddcrosby
added a commit
to dafyddcrosby/chefstyle
that referenced
this pull request
Jan 30, 2024
Chefstyle was merged into Cookstyle in chef/cookstyle#968, and so there's no longer a reason to keep a separate repository. Any future fixes to the Chefstyle configuration should be handled in the Cookstyle repository. Once all the Chef github org repositories and major reverse dependencies on the gem (https://rubygems.org/gems/chefstyle/reverse_dependencies) are addressed, it can be sent to chef-boneyard. Signed-off-by: David Crosby <dcrosby@fb.com>
11 tasks
sean-simmons-progress
pushed a commit
to chef/chefstyle
that referenced
this pull request
Feb 6, 2024
Chefstyle was merged into Cookstyle in chef/cookstyle#968, and so there's no longer a reason to keep a separate repository. Any future fixes to the Chefstyle configuration should be handled in the Cookstyle repository. Once all the Chef github org repositories and major reverse dependencies on the gem (https://rubygems.org/gems/chefstyle/reverse_dependencies) are addressed, it can be sent to chef-boneyard. Signed-off-by: David Crosby <dcrosby@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's already a lot of overlap with Chefstyle, and maintaining one repo instead of two makes development and maintenance easier for everyone. I've imported the files from
main(currently https://github.com/chef/chefstyle/tree/129344227d927ea67f228540654a6718265d03cd) and only changed chefstyle.yml as Chef/Ruby/Ruby27KeywordArgumentWarnings is already available in Cookstyle asChef/Deprecations/Ruby27KeywordArgumentWarnings.To run the chefstyle configs one uses the
--chefstyleargument (captured inbin/cookstyleto avoid more invasive patching of RuboCop), which useschefstyle.ymlinstead ofcookstyle.yml.Diff of
bin/chefstyle --show-copsin chefstyle repo andbin/cookstyle --chefstyle --show-cops: https://gist.github.com/dafyddcrosby/417dde82d1507313f59dae80898c5271While this makes the imported
Chef/Rubycops available to Cookstyle, they are disabled by default. Before and after diff ofcookstyle --show-cops: https://gist.github.com/dafyddcrosby/922112f26f0d90f66a4d7b832f7a465aRelated Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.