Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed license for thin and sqlite3-ruby #262

Open
wants to merge 1 commit into
base: 1-stable
Choose a base branch
from

Conversation

antima-gupta
Copy link

Description

  • Reverted the changes for license for thin and sqlite3-ruby gem.

Related Issue

#2535

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: antima-gupta <agupta@msystechnologies.com>
@PrajaktaPurohit
Copy link
Contributor

I expect for chef-server omnibus we will need to create the branch off of 1-stable and merge to 1-stable.

@antima-gupta antima-gupta changed the base branch from master to 1-stable June 22, 2021 12:49
@PrajaktaPurohit
Copy link
Contributor

chef-server uses 1-stable branch of license_scout for the omnibus pipeline These libs are included with the update to rails6. Currently the adhoc pipeline is green: https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2812 hence reverting this change.

chef-server uses master branch of license_scout for the verify pipeline. Verify fails with the license error at https://buildkite.com/chef/chef-chef-server-master-verify/builds/4230#ad6cc4db-698d-4d2b-a99f-e7120c23b701/970-1005. The fix for that should be chef/chef-server@2101261

Copy link
Contributor

@PrajaktaPurohit PrajaktaPurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants