Add failing test when not using binmode in Windows

Signed-off-by: Ken MacLeod <ken.macleod@csgi.com>
chef · Jan 12, 2019 · da095f9 · da095f9
1 parent 8a20097
commit da095f9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/spec/fixtures/fixture_binary b/spec/fixtures/fixture_binary
diff --git a/spec/mixlib/lib_archive_spec.rb b/spec/mixlib/lib_archive_spec.rb
@@ -24,7 +24,7 @@
   describe "#create" do
     let(:test_root) { Dir.mktmpdir(nil) }
     let(:archive_path) { File.join(test_root, "test.tar.gz") }
-    let(:file_paths) { %w{ . .. fixture_a fixture_b fixture_c } }
+    let(:file_paths) { %w{ . .. fixture_a fixture_b fixture_c fixture_binary } }
 
     context "using the correct options" do
       it "requests the correct tar format" do
@@ -51,6 +51,7 @@
       target = File.join(test_root, "target")
       Mixlib::Archive::LibArchive.new(archive_path).extract(target)
       expect(Dir.entries(target)).to match_array file_paths
+      expect(File.size("#{target}/fixture_binary")).to eql 6
     end
 
   end

diff --git a/spec/mixlib/tar_spec.rb b/spec/mixlib/tar_spec.rb
@@ -61,7 +61,7 @@
   describe "#create" do
     let(:test_root) { Dir.mktmpdir(nil) }
     let(:archive_path) { File.join(test_root, "test.tar.gz") }
-    let(:file_paths) { %w{ . .. fixture_a fixture_b fixture_c } }
+    let(:file_paths) { %w{ . .. fixture_a fixture_b fixture_c fixture_binary } }
 
     it "creates a tarball" do
       Dir.chdir(fixtures_path) do
@@ -71,6 +71,7 @@
       target = File.join(test_root, "target")
       Mixlib::Archive::LibArchive.new(archive_path).extract(target, ignore: %w{ . .. })
       expect(Dir.entries(target)).to match_array file_paths
+      expect(File.size("#{target}/fixture_binary")).to eql 6
     end
 
   end

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -3,6 +3,7 @@
 require "mixlib/archive"
 require "mixlib/archive/tar"
 require "mixlib/archive/lib_archive"
+require "pathname"
 
 module Fixtures
   def fixtures_path