Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive select timeout #252

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dafyddcrosby
Copy link
Contributor

[NOTE] tests are being handled separately in #246, those commits will be gone once this has been rebased

Description

There doesn't appear to be a reason as to why READ_WAIT_TIME is 10 milliseconds, but that can be an excessive amount of time for quick shellouts. However, syscalls aren't 'free', so simply changing READ_WAIT_TIME to 1 millisecond would increase load where there's This PR adds a progressive timeout mechanism so that the timeout latency incrementally increases up to READ_WAIT_TIME.

Related Issue

#245

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

This fixes the assumption that `ruby` is always available from PATH.

Signed-off-by: David Crosby <dcrosby@fb.com>
Signed-off-by: David Crosby <dcrosby@fb.com>
This intends to strike a balance between quick and longer-running shellouts

Signed-off-by: David Crosby <dcrosby@fb.com>
Copy link

sonarcloud bot commented Nov 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant