Add cgroupv2 support for linux shellouts #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `cgroup` attribute is provided, it will execute the command within a specific cgroupv2, creating it if missing Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
Not only check there's _a_ cgroupv2 tree mounted, but check it's also in the expected path Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
tpowell-progress
requested changes
Feb 18, 2025
tpowell-progress
added
the
Status: Waiting on Contributor
11 tasks
Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
|
Looks like I broke the Windows tests despite adding :linux_only, gonna attempt to repro and fix |
As cgroups is a linux concept, so it makes sense to run the cgroup tests only on this platform Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@ima.lol>
Signed-off-by: Imanol-Mikel Barba Sabariego <imanol@imanolbarba.net>
|
|
@tpowell-progress ping for review :) |
jaymzh
approved these changes
Feb 25, 2025
tpowell-progress
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to implement cgroupv2 support for shellouts, allowing the user to specify under which cgroup should the command be executed.
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.