Erroneous build delay

[lusis]

I think I've found a small bug that's causing dependencies to fail. I need to map out a proper test case but here's what I think is happening:

• The docs state that deps explicitly named in a project file are built last
• I'm sort of okay with this but previously I was explicitly ordering my builds in the project so small cognitive shift

So let's say I erroneously put openssl in my project file (let's says the first item). And I also have openssl as a dep in something else.

I think what's happening is that the dedupe is shifting explicit deps in a project to the end regardless of a software definition's deps.

So take a software def called nginx that says:

name "nginx"
default_version "1.4.3.6"

dependency "geoip"
dependency "zlib"
dependency "openssl"
dependency "libxml2"
dependency "libxslt"
dependency "pcre"
dependency "gd"
dependency "ngx_http_gunzip_filter_module"
dependency "ngx_http_filter_cache"
dependency "nginx_upstream_check_module"
dependency "nginx_http_jsonp_module"
dependency "ngx_cache_purge"
dependency "nginx-statsd"
dependency "nginx_requestid"
dependency "nginx_upstream_fair_module"
dependency "nginx-sticky-module"
dependency "nginx_tcp_proxy_module"

with a project like so:

dependency "preparation"
dependency "openssl"
dependency "mything" # mything has a dep on openssl and the above software def.

So I think the dedupe happens first (again I haven't validated) and THEN the explicit deps are shifted to the end. So that means openssl gets shifted to then end.

I'll try and validate this but I wanted to get this out there.

[johnbellone]

I am seeing dependencies not being executed. In particular preparation.

[schisamo]

@hosh Does this look like the issue you stumbled across in omnibus-chef-server? /cc @adamhjk

[adamhjk]

That's totally it

[johnbellone]

Just confirmed this too. I had something being depended on twice and observed this.

[johnbellone]

Perhaps using solve for dependencies may be a good fix here?

[sethvargo]

@johnbellone solve has a dependency on Gecode and some other stuff. I doubt you want it to solve the graph for you.

[johnbellone]

@sethvargo Gotcha, testing something out now :).

[adamhjk]

The fix is small - I can make it today if nobody else beats me to it.
On Apr 23, 2014 7:13 AM, "John Bellone" notifications@github.com wrote:

@sethvargo https://github.com/sethvargo Gotcha, testing something out
now :).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-41165459
.

[adamhjk]

Just opened a PR on this.

[johnbellone]

Woot!

[adamhjk]

This is fixed and merged.

Both Seth's are out on vacation, so a release is pending. 👍