Make RPM packaging use threaded compression #1132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we set `_binary_payload` on RPM packages, we override the selection of compression algorithm defaults; in this case, we specifically choose a non-threaded compression mode. Unfortunately, this means that compression with any compression algorithm other than GZip can take a very long time. Debian packages, on the other hand, use threaded compression modes by default. This change forces `_binary_payload` to use threaded compression modes when selecting an algorithm and compression level. Signed-off-by: Ryan Egesdahl <deriamis@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because we set
_binary_payloadon RPM packages, we override the selection of compression algorithm defaults; in this case, we specifically choose a non-threaded compression mode. Unfortunately, this means that compression with any compression algorithm other than GZip can take a very long time. Debian packages, on the other hand, use threaded compression modes by default.This change forces
_binary_payloadto use threaded compression modes when selecting an algorithm and compression level.Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan