Support ERB templates in software. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2013 22:23
|
I see this being very useful. What say you @christophermaier, @danielsdeleo and @lamont-granquist? |
| block do | ||
| template = ERB.new(File.new(source_path).read, nil, "%") | ||
| File.open(args[:dest], "w") do |file| | ||
| file.write(template.result(OpenStruct.new(args[:vars]).instance_eval { binding })) |
There was a problem hiding this comment.
What's the OpenStruct here for? To let you access variables in your template as methods? I have kind of a pathological hatred of OpenStruct because it has the most performance hostile implementation possible for a ruby library, but performance of the ruby code in Omnibus isn't the critical path, so maybe I can get over it.
|
Seems like a useful feature to me. |
|
works for me |
schisamo
added a commit
that referenced
this pull request
Dec 4, 2013
Support ERB templates in software.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a lot of these, I imagine others might find this useful as well.