Praj/rebase with upstream #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate use of module_info to check whether a module exports a function
Make webmachine_mochiweb loop call use latest version of module
This reverts commit 5546d5a.
…_dependency Upgrade mochiweb dependency
Suppress stacktrace-related warnings in OTP21
OTP 21 compatibility
… not 1xx or 204. Signed-off-by: Prajakta Purohit <prajakta@opscode.com>
…nt_length no Content-Length in header if response code is 1xx or 204
…> webmachine:headers()
…eaders_headers_type Fixed type reference in wm_reqdata.hrl
Using httpd_util:rfc1123_date/1 converts the date from local time to GMT. This makes the test case fail in any time zone east of GMT (but pass in GMT or a time zone west of GMT). To avoid this, we have to first convert the time to GMT via that function and then convert it back to Erlang date time. This way, we make sure we use exactly the same date in both Last-Modified and in If-Modified-Since, honoring the original intent of the test case.
The latest version of mochiweb can't be found in hex and the current project owner does not have control to publish a new version. In order to have webmachine be more compatible with erlang 21, the mochiweb version needs to be upgraded as the "tuple calls" have officially been removed from the language.
Update mochiweb dependency to git
Use correct date for L17 test
…mochiweb-options
webmachine_mochiweb: change LoopFun to an {M,F,As} tuple
Signed-off-by: Prajakta Purohit <prajakta@chef.io>
… the conditional for supporting the olderversions of Erlang. Any version > R13 can support this code. Signed-off-by: Prajakta Purohit <prajakta@chef.io>
…er than R15. Since we don't support versions that old, removing this script. Signed-off-by: Prajakta Purohit <prajakta@chef.io>
mochiweb -> master ibrowse -> chef/ibrowse ma/revert_ipv6 Signed-off-by: Lincoln Baker <lbaker@chef.io>
===> Compiling _build/default/lib/webmachine/src/webmachine_resource.erl failed _build/default/lib/webmachine/src/webmachine_resource.erl:205: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace Signed-off-by: Lincoln Baker <lbaker@chef.io>
PrajaktaPurohit
force-pushed
the
praj/rebase_with_upstream
branch
from
04d5e26 to
d7b5a10
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.