Use hex strings for filter block handler indices MetaMask#155

Using the numeric index `self.filterIndex` results in problems later on when we try to uninstall handler.
chejazi · May 30, 2017 · c0a9da1 · c0a9da1
1 parent 30f993e
commit c0a9da1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/subproviders/filters.js b/subproviders/filters.js
@@ -131,8 +131,8 @@ FilterSubprovider.prototype.newLogFilter = function(opts, cb) {
     }
 
     self.filterIndex++
-    self.asyncBlockHandlers[self.filterIndex] = blockHandler
     var hexFilterIndex = intToHex(self.filterIndex)
+    self.asyncBlockHandlers[hexFilterIndex] = blockHandler
     self.filters[hexFilterIndex] = filter
 
     cb(null, hexFilterIndex)
@@ -153,8 +153,8 @@ FilterSubprovider.prototype.newPendingTransactionFilter = function(cb) {
   }
 
   self.filterIndex++
-  self.asyncPendingBlockHandlers[self.filterIndex] = blockHandler
   var hexFilterIndex = intToHex(self.filterIndex)
+  self.asyncPendingBlockHandlers[hexFilterIndex] = blockHandler
   self.filters[hexFilterIndex] = filter
 
   cb(null, hexFilterIndex)