Merge pull request #126 from chelnak/handle_pre_releases

Handle Pre-Releases

internal/utils/utils.go

@@ -74,17 +74,16 @@ func requestLatestRelease() (Release, error) {
 }
 
 func VersionIsGreaterThan(currentVersion, nextVersion string) bool {
- constraint, err := semver.NewConstraint(fmt.Sprintf("> %s", currentVersion))
+ currentSemVer, err := semver.NewVersion(currentVersion)
  if err != nil {
  return false
  }
 
- version, err := semver.NewVersion(nextVersion)
- if err != nil {
- return false
- }
+ // The nextVersion has already been validated by the builder
+ // so we can safely eat the error.
+ nextSemVer, _ := semver.NewVersion(nextVersion)
 
- return constraint.Check(version)
+ return nextSemVer.Compare(currentSemVer) == 1
 }
 
 func parseLocalVersion(version string) string {

internal/utils/utils_test.go

@@ -49,6 +49,11 @@ func TestIsValidSemanticVersion(t *testing.T) {
  value: "1.0.0",
  want: true,
  },
+ {
+ name: "valid semantic version with pre-release",
+ value: "1.0.0-beta",
+ want: true,
+ },
  {
  name: "invalid semantic version",
  value: "asdasdasd1",
@@ -86,6 +91,21 @@ func TestVersionIsGreaterThan(t *testing.T) {
  value: "1.0.0",
  want: false,
  },
+ {
+ name: "when the version is greater with pre-release",
+ value: "1.0.1-beta",
+ want: true,
+ },
+ {
+ name: "version is not greater than with pre-release",
+ value: "0.2.0-beta",
+ want: false,
+ },
+ {
+ name: "when the version is equal with pre-release",
+ value: "1.0.0-beta",
+ want: false,
+ },
  }
 
  for _, tt := range tests {